I don't think I should have to do this

[ewx]

--- server/play.c       2008-03-03 22:56:22 +0000
+++ server/play.c       2008-03-09 11:10:46 +0000
@@ -389,8 +390,14 @@
       /* np will be the pipe to disorder-normalize */
       if(socketpair(PF_UNIX, SOCK_STREAM, 0, np) < 0)
         fatal(errno, "error calling socketpair");
+      /* Beware of the Leopard!  On OS X 10.5.x, the order of the shutdown
+       * calls here DOES MATTER.  If you do the SHUT_WR first then the SHUT_RD
+       * fails iwth "Socket is not connected".  I think this is a bug but
+       * provided implementors either don't care about the order or all agree
+       * about the order, choosing the reliable order is an adequate
+       * workaround.  */
+      xshutdown(np[1], SHUT_RD);       /* decoder writes to np[1] */
       xshutdown(np[0], SHUT_WR);       /* normalize reads from np[0] */
-      xshutdown(np[1], SHUT_RD);       /* decoder writes to np[1] */
       blocking(np[0]);
       blocking(np[1]);
       /* Start disorder-normalize */

Comments

[simont]

That does seem a bit ick, although it has the saving grace of giving you an excellent excuse to use that comment :-)

JOOI, what's a socketpair with one direction shut down got that a simple pipe hasn't?

[ewx.livejournal.com]

It lacks the insane PIPE_BUF rules.

[gerald_duck]

On a related note, what's a socketpair with one direction shut down got that a socketpair with both directions still running hasn't?

[ewx.livejournal.com]

Means you spot errors more quickly if you get the ends back to front l-)

[simont]

Are those rules impeding something specific you want to do with the pipe/socketpair, or do you just avoid pipes on general principles just in case?

(I always use actual pipes when I want a thing that looks basically like a pipe, and the PIPE_BUF rules have never bitten me yet. I'm curious to know whether I'm being unconscionably reckless or whether you're doing something particularly demanding ;-)

[ewx.livejournal.com]

It's imaginable that someone's decoder might want to do nonblocking output to that FD, though neither of the shipped decoders do so at the moment.

[pjc50.livejournal.com]

The sound of one pipe sucking?

[ewx.livejournal.com]

Oh, also, a socketpair with one direction shut down is unidirectional, whereas a pipe will be bidirectional on some systems.

[mstevens.livejournal.com]

You spelt "with" wrong in the comment.

[ewx.livejournal.com]

Oops l-)